Skip to content

feat(react-router): server action revalidation opt out via $SKIP_REVALIDATION field. #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025

Conversation

jacob-ebey
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Aug 12, 2025

🦋 Changeset detected

Latest commit: 7515942

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title feat: server action revalidation opt out via $NO_REVALIDATE field. feat(react-router): server action revalidation opt out via $NO_REVALIDATE field. Aug 14, 2025
@jacob-ebey jacob-ebey changed the base branch from dev to release-next August 21, 2025 17:32
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Mostly minor/nitpicky comments 😬

@jacob-ebey jacob-ebey changed the title feat(react-router): server action revalidation opt out via $NO_REVALIDATE field. feat(react-router): server action revalidation opt out via $SKIP_REVALIDATION field. Aug 21, 2025
filterMatchesToLoad || null,
"filterMatchesToLoad" in opts
? (opts.filterMatchesToLoad ?? null)
: null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to fall back on the original value here if they didn't pass an override?

Suggested change
: null,
: (filterMatchesToLoad ?? null),

I should go through and clean up some of the null/undefined stuff in here one of these days 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we need it for the first half of the ternary in case they specified an undefined key - they shouldn't, but the types would allow it. Maybe this is easier?

opts.filterMatchesToLoad ?? filterMatchesToLoad ?? null,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's different behavior. It should be "if provided, use it (undefined, null, new imp), otherwise use default", we need the key check for that.

@jacob-ebey jacob-ebey merged commit bebb46c into release-next Aug 21, 2025
8 checks passed
@jacob-ebey jacob-ebey deleted the rsc-no-revalidate branch August 21, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants