-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
feat(react-router): server action revalidation opt out via $SKIP_REVALIDATION
field.
#14154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7515942 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
$NO_REVALIDATE
field.$NO_REVALIDATE
field.
07ddf5f
to
9b4ea5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Mostly minor/nitpicky comments 😬
9b4ea5a
to
e6e60a6
Compare
e6e60a6
to
28a7351
Compare
$NO_REVALIDATE
field.$SKIP_REVALIDATION
field.
filterMatchesToLoad || null, | ||
"filterMatchesToLoad" in opts | ||
? (opts.filterMatchesToLoad ?? null) | ||
: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to fall back on the original value here if they didn't pass an override?
: null, | |
: (filterMatchesToLoad ?? null), |
I should go through and clean up some of the null
/undefined
stuff in here one of these days 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we need it for the first half of the ternary in case they specified an undefined key - they shouldn't, but the types would allow it. Maybe this is easier?
opts.filterMatchesToLoad ?? filterMatchesToLoad ?? null,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's different behavior. It should be "if provided, use it (undefined, null, new imp), otherwise use default", we need the key check for that.
No description provided.